ci(targeted-verification): let "Re-run failed jobs" find the shard selection by khaliqgant · Pull Request #2001 · AgentWorkforce/relay

khaliqgant · 2026-10-27T07:47:04Z

Problem

targeted-feature-verification.yml uploads the shard selection as targeted-feature-selection-${{ github.run_id }}-${{ github.run_attempt }} from the select job, and each Flows v2 shard downloads the same name. Re-run failed jobs only re-runs the failed shards; select succeeded, so it is not re-run and nothing uploads an artifact for the new run_attempt. Every re-attempted shard then fails at Download immutable selection with Artifact not found, so the only way to retry a flaky shard was to re-run the whole workflow.

Fix

Name the selection artifact targeted-feature-selection-${{ github.run_id }} (no run_attempt) in both the upload and download steps. Artifacts uploaded by an earlier attempt are still listed for later attempts of the same run, so a re-attempted shard downloads the selection the original select job produced.
Upload with overwrite: true. With upload-artifact v4, uploading a name that already exists in the run is a 409 conflict, which would otherwise break Re-run all jobs (where select runs again). The selection is computed from the same base/head SHAs, so replacing it is equivalent.
Per-shard evidence artifacts (targeted-feature-plan-...-${{ github.run_attempt }}-<shard>) keep run_attempt. Each attempt uploads its own, so they don't collide.
Added a fixture test assertion that pins the run-scoped name and overwrite: true.

Test plan

actionlint (rhysd/actionlint docker image) clean
npx vitest run tests/fixtures/targeted-feature-verification.test.ts -t "workflow|Re-run" passes
After merge: re-run only a failed shard on a PR and confirm the download step succeeds

🤖 Generated with Claude Code

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Agent Relay sessions

claude session a5019981 · opened via gh pr create · last active 2026-10-27

…lection The selection artifact was named with run_attempt, but "Re-run failed jobs" does not re-run the select job, so re-attempted shards looked for an artifact from the new attempt that was never uploaded and failed with "Artifact not found". Key the artifact by run_id only (earlier attempts' artifacts remain downloadable within the same run) and upload with overwrite: true so "Re-run all jobs" can replace it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector · 2026-10-27T07:47:14Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-27T07:48:27.892235Z	`137b1a1`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-27T07:47:21Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 6fe33785-4a73-4f54-b45f-9b0a737ebd47

Commits

Reviewing files that changed from the base of the PR and between 137b1a1 and 9fcdbdc.

Files selected for processing: 1

tests/fixtures/targeted-feature-verification.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

The targeted feature verification workflow now names its shard-selection artifact by run ID, overwrites the artifact on upload, and downloads it using the same name. A workflow test checks these settings.

Changes: Shard-selection artifact reuse

Layer / File(s)	Summary
Artifact naming and verification `.github/workflows/targeted-feature-verification.yml`, `tests/fixtures/targeted-feature-verification.test.ts`	The workflow uses `github.run_id` for artifact upload and download. Uploads enable `overwrite: true`. The test checks both artifact names and the overwrite setting.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

AgentWorkforce/relay#1345: Changes the feature manifest and verification procedures that contribute to the shard-selection artifact.
AgentWorkforce/relay#1983: Changes feature manifest inputs read by the targeted verification workflow.

Merge Risk: Minimal · up to 9fcdb

The rerun artifact path is aligned and verified by the fixture; no merge-blocking risk remains.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description clearly explains the problem, fix, affected artifacts, and test results. However, it omits the required RelayFlow Proof section and does not provide the required change type or case va…	Add the RelayFlow Proof section with a valid Change type and RelayFlow case. Use non-functional and n/a if runtime behavior is unchanged.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: allowing failed targeted-verification jobs to find the shard selection artifact.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Full details: Description check

Explanation

The description clearly explains the problem, fix, affected artifacts, and test results. However, it omits the required RelayFlow Proof section and does not provide the required change type or case values.

Resolution

Add the RelayFlow Proof section with a valid Change type and RelayFlow case. Use non-functional and n/a if runtime behavior is unchanged.

Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{A rabbit checks the run ID twice,
The artifact keeps its matching name.
It may be replaced on a rerun,
Then downloaded without a change.
The workflow test confirms the way,
And hops along its verified day.}

_{Comment @coderabbitai help to get the list of available commands.}

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

greptile-apps · 2026-10-27T07:49:01Z

Confidence Score: 5/5

[Low impact] The PR appears safe to merge; no blocking issues remain.

Summary

The PR gives shard selection artifacts a run-scoped name so failed shards can reuse them on retry.

Failed shards can reuse the selection artifact from their workflow run.

_{Reviews (2) · Last reviewed commit: "test(targeted-verification): assert sele..." · Reviewed by Greptile}

Parse the workflow and check the upload/download steps directly so the overwrite assertion cannot match a different step. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

khaliqgant requested a review from willwashburn as a code owner October 27, 2026 07:47

devin-ai-integration Bot reviewed Oct 27, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 27, 2026

View reviewed changes

Comment thread tests/fixtures/targeted-feature-verification.test.ts Resolved

test(targeted-verification): assert selection artifact via parsed steps

9fcdbdc

Parse the workflow and check the upload/download steps directly so the overwrite assertion cannot match a different step. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

khaliqgant merged commit e6fcba4 into main Oct 27, 2026
76 checks passed

khaliqgant mentioned this pull request Oct 29, 2026

feat(cli): relay init injects messages through the Agent Relay core (probe phase 3) #2016

Merged

Navigation Menu

Repository navigation

ci(targeted-verification): let "Re-run failed jobs" find the shard selection - #2001

ci(targeted-verification): let "Re-run failed jobs" find the shard selection#2001
khaliqgant merged 2 commits into
mainfrom
ci/targeted-verification-rerun

khaliqgant commented Oct 27, 2026 •

edited by agent-relay-code Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

greptile-apps Bot commented Oct 27, 2026 •

edited

Loading

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

khaliqgant commented Oct 27, 2026 • edited by agent-relay-code Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Test plan

Uh oh!

chatgpt-codex-connector Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

greptile-apps Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

khaliqgant commented Oct 27, 2026 •

edited by agent-relay-code Bot

Loading

chatgpt-codex-connector Bot commented Oct 27, 2026 •

edited

Loading

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading

greptile-apps Bot commented Oct 27, 2026 •

edited

Loading